On 11/02/15 10:32, Jan Beulich wrote: >>>> On 11.02.15 at 11:05, <andrew.coop...@citrix.com> wrote: >> On 11/02/15 07:50, Jan Beulich wrote: >>> I'd like to propose to honor the 'd' in these functions' names (which >>> I understand to mean "debug") in that such functions should be >>> no-ops in non-debug builds. I'd then be inclined to introduce a >>> gprintk() automatically adding XENLOG_GUEST and the printing of >>> current using the %pv format. Quite likely the (mis-)use of these >>> two functions may then temporarily result in messages not meant >>> to be debugging ones to become hidden in non-debug builds. If >>> others agree, I'd try to make one pass through the tree to try to >>> identify such, but I'd like to ask others to also keep an eye on that >>> aspect. >> I agree. I suspect many of the existing gdprintk()s will need to turn >> into dprintk()s. > Maybe, but that's yet another topic (unless you meant gprintk()s > instead of dprintk()s).
I did mean gprintk(). Sorry. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
