>>> On 20.03.17 at 13:51, <paul.durr...@citrix.com> wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 20 March 2017 12:26 >> >>> On 17.03.17 at 10:57, <paul.durr...@citrix.com> wrote: >> > --- a/xen/arch/x86/hvm/viridian.c >> > +++ b/xen/arch/x86/hvm/viridian.c >> > @@ -22,6 +22,12 @@ >> > #include <public/sched.h> >> > #include <public/hvm/hvm_op.h> >> > >> > +#define VIRIDIAN_SPINLOCK_RETRY_COUNT_DEFAULT 2047 >> > + >> > +static int __read_mostly viridian_spinlock_retry_count; >> >> Why don't you simply initialized the variable to 2047? None of ... >> > > I wasn't sure whether that was ok in Xen. I was following other code (mainly > from grant table) as a template.
That other approach in grant table code has, iirc, some other reason. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel