>>> On 17.03.17 at 07:46, <haozhong.zh...@intel.com> wrote: > --- a/xen/include/public/hvm/params.h > +++ b/xen/include/public/hvm/params.h > @@ -259,6 +259,11 @@ > */ > #define HVM_PARAM_VM86_TSS_SIZED 37 > > -#define HVM_NR_PARAMS 38 > +/* Enable MCA capabilities. */ > +#define HVM_PARAM_MCA_CAP 38 > +#define HVMMCA_CAP_LMCE (1UL << 27)
How come this is bit 27 rather than bit 0? Further, to match up with other, future definitions here, I think you mean 1ULL (or, to be precise, xen_mk_ullong()). > +#define HVMMCA_CAP_MASK HVMMCA_CAP_LMCE For both of these, please add XEN_ at the front (perhaps replacing HVM, or if not, add another underscore between HVM and MCA). Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
