On 17/02/15 15:57, Jan Beulich wrote: >>>> On 17.02.15 at 11:02, <andrew.coop...@citrix.com> wrote: >> On 16/02/15 23:05, Don Slutz wrote: >>> --- a/xen/include/asm-x86/hvm/hvm.h >>> +++ b/xen/include/asm-x86/hvm/hvm.h >>> @@ -356,6 +356,13 @@ static inline unsigned long >>> hvm_get_shadow_gs_base(struct vcpu *v) >>> #define has_viridian_time_ref_count(d) \ >>> (is_viridian_domain(d) && (viridian_feature_mask(d) & >>> HVMPV_time_ref_count)) >>> >>> +#define vmware_feature_mask(d) \ >>> + (has_hvm_params(d) ? \ >>> + (d)->arch.hvm_domain.params[HVM_PARAM_VMWARE_HWVER] : 0) >> I can't spot any use of this vmware_feature_mask(). Is it stale? > No, it is being used ... > >> Otherwise, Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> >> >>> + >>> +#define is_vmware_domain(d) \ >>> + (is_hvm_domain(d) && vmware_feature_mask(d)) > ... here. > > Jan >
So it is. I am clearly blind. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
