> On 03/04/17 14:42, Daniel Kiper wrote: > > On Fri, Mar 31, 2017 at 12:14:38PM +0200, Juergen Gross wrote: > >> For kdump to work correctly it needs the physical address of > >> vmcoreinfo_note. When running as dom0 this means the virtual address > >> has to be translated to the related machine address. > >> > >> paddr_vmcoreinfo_note() is meant to do the translation via > >> __pa_symbol() only, but being attributed "weak" it can be replaced > >> easily in Xen case. > >> > >> Signed-off-by: Juergen Gross <jgr...@suse.com> > > > > Have you tested this patch with latest crash tool? Do dom0 and Xen > > hypervisor analysis work without any issue (at least basic commands > > like dmesg, bt, ps, etc.)? If yes for both you can add: > > > > Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com> > > This patch isn't for dump analysis, but for dump creation. Petr has
I know that. However, it may have impact on crash analysis. So, I would expect that you or anybody else in your behalf will do at least minimal crash tool tests. > verified that the dump is in the expected format. Please ask Petr > for further details, e.g. user side modifications being necessary. So, if Petr did relevant tests that is nice. However, then, IMO, this patch begs Petr Tested-by. Daniel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
