>>> On 05.04.17 at 19:33, <andrew.coop...@citrix.com> wrote: > With the SVM injection logic capable of doing its own emulation, there is no > need for this hardware-specific assistance in the common emulator. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > Reviewed-by: Paul Durrant <paul.durr...@citrix.com> > Reviewed-by: Jan Beulich <jbeul...@suse.com> > --- > CC: Tim Deegan <t...@xen.org> > CC: Julien Grall <julien.gr...@arm.com> > > v2: > * imm8 -> imm1
This went wrong: > case 0xce: /* into */ > if ( !(_regs.eflags & X86_EFLAGS_OF) ) > break; > - src.val = EXC_OF; > - swint_type = x86_swint_into; > - goto swint; > + /* Fallthrough */ > + case 0xcc: /* int3 */ > + case 0xcd: /* int imm1 */ This needs to remain imm8. > + case 0xf1: /* int1 (icebp) */ > + ASSERT(!ctxt->event_pending); > + switch ( ctxt->opcode ) > + { > + case 0xcc: /* int3 */ > + ctxt->event.vector = EXC_BP; > + ctxt->event.type = X86_EVENTTYPE_SW_EXCEPTION; > + break; > + case 0xcd: /* int imm1 */ As does this one. > + ctxt->event.vector = src.val; This is what I would prefer to become imm1. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel