On 04/06/17 01:54 -0600, Jan Beulich wrote: > >>> On 06.04.17 at 06:55, <haozhong.zh...@intel.com> wrote: > > 1. Move them into mcheck_cmn_handler() which is their only user. > > This part is uncontroversial. > > > 2. Always (re-)initialize them to clear historical information. > > But without further explanation I'm not convinced this part is correct. > That's a good indication that you should split patches. > > I assume, btw, that you're aware that these patches won't go > in very soon (not until after 4.9 has been branched off), unless > they fix an actual bug. >
Please drop this patch as it does not fix any bug. I was blind. 'found_error' is already cleared after mcheck_cmn_handler() used it. Non-empty 'mce_fatal_errors' results in mc_panic(), so there is no need to clear it. Sorry for the noise. Haozhong _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
