>>> On 06.04.17 at 02:30, <chao....@intel.com> wrote:
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -438,6 +438,9 @@ static int hvm_migrate_pirq(struct domain *d, struct
> hvm_pirq_dpci *pirq_dpci,
> struct vcpu *v = arg;
>
> if ( (pirq_dpci->flags & HVM_IRQ_DPCI_MACH_MSI) &&
> + (pirq_dpci->flags & HVM_IRQ_DPCI_GUEST_MSI) &&
> + /* Needn't migrate pirq if this pirq is delivered to guest
> directly.*/
> + (!pirq_dpci->gmsi.posted) &&
> (pirq_dpci->gmsi.dest_vcpu_id == v->vcpu_id) )
> {
I don't think I've seen you address Kevin's comment on this for v11,
and like Kevin I can't immediately see why the above addition would
be correct. Do you perhaps mean
if ( (pirq_dpci->flags & HVM_IRQ_DPCI_MACH_MSI) &&
/* Needn't migrate pirq if this pirq is delivered to guest directly.*/
(!pirq_dpci->gmsi.posted ||
<whatever is appropriate here, if anything>) &&
(pirq_dpci->gmsi.dest_vcpu_id == v->vcpu_id) )
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
