On Thu, May 11, 2017 at 12:13:00PM +0100, Ian Jackson wrote: > Roger Pau Monne writes ("[PATCH v2 2/2] libxl/devd: correctly manipulate the > dguest list"): > > Current code in backend_watch_callback has two issues when manipulating the > > dguest list: > ... > > skip: > > libxl__nested_ao_free(nested_ao); > > +clean: > > if (ddev) > > free(ddev->dev); > > This is starting to be quite goto-rich, and the memory ownership rules > become less clear. Rather than try to analyse this in detail, I > wonder if it would be better to try to rework this so that it fits > CODING_STYLE better. > > Wei, what do you think ? >
No objection from me, of course. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel