On Sat, 2017-06-17 at 15:02 +0530, Praveen Kumar wrote: > --- a/xen/common/rbtree.c > +++ b/xen/common/rbtree.c > @@ -90,8 +90,23 @@ void rb_insert_color(struct rb_node *node, struct > rb_root *root) > { > struct rb_node *parent, *gparent; > > - while ((parent = rb_parent(node)) && rb_is_red(parent)) > + while (true) > { > And here we are again. (I.e., in the cited Linux's commit, this is being turned into 'while (true) {`.
So, I think we should gather others' opinion about how to deal with these aspects of this series. So, I'll stop my review for now, and chase feedback. Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel