On Fri, Jul 28, 2017 at 05:17:12PM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH] libxl: do not start dom0 qemu for stubdomain > when not needed"): > > On Fri, Jul 28, 2017 at 06:05:13PM +0200, Marek Marczykowski-Górecki wrote: > > > On Fri, Jul 28, 2017 at 04:17:51PM +0100, Wei Liu wrote: > > > > On Thu, Jul 27, 2017 at 12:44:25AM +0200, Marek Marczykowski-Górecki > > > > wrote: > > > > > + if (libxl_defbool_val(guest_config->b_info.u.hvm.vnc.enable) || > > > > > + > > > > > libxl_defbool_val(guest_config->b_info.u.hvm.spice.enable) || > > > > > + > > > > > libxl_defbool_val(guest_config->b_info.u.hvm.sdl.enable)) { > > > > > > > > Indentation. > > > > > > Should it really be indented at the same level as the code inside this > > > block? Looks misleading (you need to look for ") {" to see where > > > condition ends). > > > > That's how existing code in libxl is like, isn't it? > > Yes. Sadly. > > If you like we could have a bunfight about changing the indent level. > I like 2, personally :-P. > > A compromise might be to move the || to the start of the next line, so > > if (cond1 > || cond2 > || cond3) { > code1; > code2; > > I have done that sometimes in libxl and no-one has objected.
Ok, it would be much better, thanks. -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing?
signature.asc
Description: PGP signature
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel