On 2017年08月22日 18:53, Wei Liu wrote: > On Tue, Aug 22, 2017 at 06:39:32PM +0800, Lan Tianyu wrote: >> On 2017年08月22日 16:42, Wei Liu wrote: >>> On Tue, Aug 22, 2017 at 04:04:09PM +0800, Lan Tianyu wrote: >>>> On 2017年08月18日 18:13, Wei Liu wrote: >>>>>>> ASSERT(info->viommu[viommu_id]->ops); >>>>>>>>> >>>>>>>>> For extra safety. >>>>>>> >>>>>>> Or check ops in the previous if? >>>>>>> >>>>> That depends on if ops can be null or not. >>>> >>>> If ops isn't be set, it will be null. Because struct viommu is allocated >>>> via xzalloc(). >>> >>> But is it functionally correct / possible to have it to be NULL when you >>> come to this path? >>> >> >> No, it shouldn't be NULL if struct viommu is set up correctly. >> > > Then an ASSERT is warranted -- hope you see the line of thinking. >
OK. I got it. Will add in the next version. -- Best regards Tianyu Lan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
