On 24/08/17 09:44, Jan Beulich wrote: > >>> On 23.08.17 at 21:09, <andrew.coop...@citrix.com> wrote: >> * These functions work in terms of linear addresses, not virtual addresses. >> Update the comments and parameter names. >> * Drop unnecessary inlines. >> * Drop vcpu parameter from guest_get_eff_kern_l1e(). Its sole caller passes >> current, and its callee strictly operates on current. > I'm not entirely convinced of this part, as I think the intention was > to save the re-latching of "current", but anyway:
It'll be inlined anyway, given a sole caller. We could have struct vcpu *curr as a parameter if you prefer, but having just a plain v gives the false impression it can be used with something other than current. ~Andrew > >> * Switch guest_get_eff_kern_l1e()'s parameter from void * to l1_pgentry_t >> *. >> Both its caller and callee already use the correct type already. >> >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > Reviewed-by: Jan Beulich <jbeul...@suse.com> > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel