>>> On 17.08.17 at 16:44, <wei.l...@citrix.com> wrote: > Move them to pv/mm.c and rename them to pv_get_guest_eff_{,kern}_l1e. > Export them via pv/mm.h.
I think these should remain static inlines. If either is really needed by more than one C file, it may be best to move it/them to a private header in x86/pv/. But guest_get_eff_kern_l1e() clearly has just a single caller. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel