On 01/09/2017 10:11, Vitaly Kuznetsov wrote:
> C/s e7dabe5 ("x86/hvm: don't unconditionally create a default ioreq
> server") broke soft reset when QEMU traditional is being used. During
> soft reset QEMU is relaunched and default ioreq server needs to be
> re-created upon first HVM_PARAM_*IOREQ_* request. The flag will be
> set back to 'true' when toolstack unpauses the domain, just like after
> normal creation.
>
> Signed-off-by: Vitaly Kuznetsov <vkuzn...@redhat.com>Sorry, but nack. d->creation_finished is used for a number of things, one being TLB safety before the vcpus have started executing. We either need to split the variable, or rework e7dabe5 to not use this. ~Andrew > --- > xen/common/domain.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/xen/common/domain.c b/xen/common/domain.c > index b22aacc57e..b529c5d7ad 100644 > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -1085,6 +1085,8 @@ int domain_soft_reset(struct domain *d) > unmap_vcpu_info(v); > } > > + d->creation_finished = false; > + > rc = arch_domain_soft_reset(d); > if ( !rc ) > domain_resume(d); _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
