On Fri, Sep 22, 2017 at 03:07:44AM -0600, Jan Beulich wrote: > Therefore all write attempts should produce #GP, just like on real > hardware. > > Signed-off-by: Jan Beulich <jbeul...@suse.com> > > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -3138,10 +3138,7 @@ static int vmx_msr_write_intercept(unsig > break; > > case MSR_INTEL_PLATFORM_INFO: > - if ( msr_content || > - rdmsr_safe(MSR_INTEL_PLATFORM_INFO, msr_content) ) > - goto gp_fault; > - break; > + goto gp_fault;
Could you place the label together with the MSR_IA32_FEATURE_CONTROL one above? So that we don't add another case with just a gp_fault. With that: Reviewed-by: Roger Pau Monné <roger....@citrix.com> Thanks, Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel