>>> On 25.09.17 at 11:16, <ppircal...@bitdefender.com> wrote: > @@ -7750,6 +7742,9 @@ x86_emulate( > unimplemented_insn: > rc = X86EMUL_UNIMPLEMENTED; > goto done; > + unrecognized_insn: > + rc = X86EMUL_UNRECOGNIZED; > + goto done; > } > Do you find this approach OK?
Yes, that's reasonable I think. > Do you think adding a "TODO:" comment can make things more clear? > e.g.: > * The current instruction's opcode is not valid. > * If this error code is returned by a function, an #UD trap should e > * raised by the final consumer of it. > + * > + * TODO: For the moment X86EMUL_UNRECOGNIZED and 86EMUL_UNIMPLEMENTED > + * can be used interchangeably. > */ Something along these lines, yes, plus an indication that the #UD raising therefore also isn't strictly being expected for now. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
