>>> On 11.10.17 at 15:35, <gregory.herr...@oracle.com> wrote: > @@ -336,16 +337,22 @@ elf_errorstatus elf_xen_parse_guest_info(struct > elf_binary *elf, > if ( !strcmp(name, "ELF_PADDR_OFFSET") ) > parms->elf_paddr_offset = strtoull(value, NULL, 0); > if ( !strcmp(name, "HYPERCALL_PAGE") ) > - parms->virt_hypercall = (strtoull(value, NULL, 0) << 12) + > - parms->virt_base; > + parms->virt_hypercall = (strtoull(value, NULL, 0) << 12);
Please also drop the now pointless parentheses. > /* other */ > if ( !strcmp(name, "FEATURES") ) > if ( elf_xen_parse_features(value, parms->f_supported, > parms->f_required) ) > - return -1; > + { > + ret = -1; > + break; > + } > } > - return 0; > + if ( (parms->virt_base != UNSET_ADDR) && Please add a blank line ahead of this addition. With those taken care of Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel