On 10/13/2017 07:26 PM, Tamas K Lengyel wrote: > On Fri, Oct 13, 2017 at 9:50 AM, Jan Beulich <jbeul...@suse.com> wrote: >>>>> On 13.10.17 at 14:50, <aisa...@bitdefender.com> wrote: >>> This patch adds the old value param and the onchangeonly option >>> to the VM_EVENT_REASON_MOV_TO_MSR event. >>> >>> The param was added to the vm_event_mov_to_msr struct and to the >>> hvm_monitor_msr function. Finally I've changed the bool_t param >>> to a bool for the hvm_msr_write_intercept function. >>> >>> Signed-off-by: Alexandru Isaila <aisa...@bitdefender.com> >>> Acked-by: Tamas K Lengyel <ta...@tklengyel.com> >> >> I think this should have been dropped with a bug having been fixed >> (for only cosmetic changes it would be fine to keep). For the bits >> where it's applicable >> Acked-by: Jan Beulich <jbeul...@suse.com> > > Indeed. It's fine for now, my ack still stands.
That was my mistake - I thought that the fix was so obvious that Tamas couldn't possibly object, and advised Alexandru to keep the ack. We'll be more careful next time. Thanks, Razvan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
