>>> On 19.03.15 at 20:29, <julien.gr...@linaro.org> wrote: > @@ -344,6 +344,13 @@ int iommu_do_domctl( > ret = iommu_do_pci_domctl(domctl, d, u_domctl); > #endif > > +#ifdef HAS_DEVICE_TREE > + if ( ret != -ENODEV) > + return ret; > + > + ret = iommu_do_dt_domctl(domctl, d, u_domctl); > +#endif > + > return ret; > }
I think inverting the if() condition and avoiding the extra return path would be better, particularly in case any new code would get added between the #endif and the final return. With that done Acked-by: Jan Beulich <jbeul...@suse.com> for the non-ARM, non-tools parts. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
