On Mon, Apr 13, 2015 at 10:09:51AM +0800, Chen, Tiejun wrote: [...] > >Hardcoded value? > > Yes. Actually, we intend to use this to present that lowmem entry, > > tools/firmware/hvmloader/e820.c: > > /* Low RAM goes here. Reserve space for special pages. */ > ... > e820[nr].addr = 0x100000; >
I don't like the idea of having two hardcoded values in different locations. Please put this value into a header file and reference it here and in hvmloader. Wei. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
