On Fri, 2015-05-08 at 11:11 +0100, Jan Beulich wrote: > >>> On 08.05.15 at 11:40, <huaitong....@intel.com> wrote: > > All comments has been addressed, just changelog is written partly. > > Certainly not. There are still hard tabs in the patch, and there was > still a pointless initializer that I had pointed out before. I didn't look > further. > Yes,there are still hard tabs and pointless initializers to be modified. Sorry for my mistakes. But which tabs should be used when I modify the file like "xen/arch/x86/cpu/mwait-idle.c" that all use hard tabs instead of soft tabs? the source code in the files inside directory "xen/arch/x86/cpu/" all use hard tabs. Thanks
> Jan > > > On Fri, 2015-05-08 at 09:35 +0100, Jan Beulich wrote: > >> >>> On 08.05.15 at 10:11, <huaitong....@intel.com> wrote: > >> > When checking the ACPI funciton of C-status, after 100 seconds sleep, > >> > the sampling value of C0 status from the xenpm tool decreases. > >> > Because C0=NOW()-C1-C2-C3-C4, when NOW() value is during idle time, > >> > NOW() value is bigger than last C-status update time, and C0 value > >> > is also bigger than ture value. if margin of the second error cannot > >> > make up for margin of the first error, the value of C0 would decrease. > >> > > >> > Signed-off-by: Huaitong Han <huaitong....@intel.com> > >> > >> Please address all comments on the previous iteration before > >> re-submitting. > >> > >> Jan > >> > > > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
