On 08/05/15 22:14, Andrew Cooper wrote: > When restoring a domain, check for unknown options in Image Header. Nothing > good will come from attempting to continue. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > CC: David Vrabel <david.vra...@citrix.com> > CC: Ian Campbell <ian.campb...@citrix.com> > CC: Ian Jackson <ian.jack...@eu.citrix.com> > CC: Wei Liu <wei.l...@citrix.com> > CC: Yang Hongyang <yan...@cn.fujitsu.com> > > --- > David: The wording of the spec disallows even adding new options without > bumping the protocol version. Do we want to relax the restriction slightly? > --- > docs/specs/libxc-migration-stream.pandoc | 5 +++-- > tools/libxc/xc_sr_restore.c | 6 ++++++ > tools/libxc/xc_sr_stream_format.h | 2 ++ > 3 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/docs/specs/libxc-migration-stream.pandoc > b/docs/specs/libxc-migration-stream.pandoc > index 520240f..fa501e7 100644 > --- a/docs/specs/libxc-migration-stream.pandoc > +++ b/docs/specs/libxc-migration-stream.pandoc > @@ -131,11 +131,12 @@ version 0x00000002. The version of this > specification. > > options bit 0: Endianness. 0 = little-endian, 1 = big-endian. > > - bit 1-15: Reserved. > + bit 1-15: Reserved. (Must be zero) > -------------------------------------------------------------------- > > The endianness shall be 0 (little-endian) for images generated on an > -i386, x86_64, or arm host. > +i386, x86_64, or arm host. The receiving side should confirm that no > +unexpected options have been specified.
The image header provides information about the format of the image. I suppose one could make an argument that an checkpointed stream is an infinite stream vs finite, but I think a CHECKPOINT_ENABLE record might be better? David _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
