Chunyan Liu writes ("[Xen-devel] [PATCH V4 1/7] libxl: export some functions for pvusb use"): > Signed-off-by: Chunyan Liu <cy...@suse.com> > Signed-off-by: Simon Cao <caobosi...@gmail.com> > Acked-by: Wei Liu <wei.l...@citrix.com> ... > /* generic callback for devices that only need to set ao_complete */ > -static void device_addrm_aocomplete(libxl__egc *egc, libxl__ao_device *aodev) > +void device_addrm_aocomplete(libxl__egc *egc, libxl__ao_device *aodev)
Functions in libxl with external linkage should have the appropriate namespacing (ie, their names must start with libxl__). So, I'm afraid, contrary to Wei's opinion: Nacked-by: Ian Jackson <ian.jack...@eu.citrix.com> Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel