>>> On 12.06.15 at 08:31, <tiejun.c...@intel.com> wrote: > On 2015/6/11 17:28, Tian, Kevin wrote: >>> From: Chen, Tiejun >>> Sent: Thursday, June 11, 2015 9:15 AM >>> @@ -1940,7 +1942,8 @@ static int intel_iommu_remove_device(u8 devfn, struct >>> pci_dev >>> *pdev) >>> PCI_DEVFN2(bdf) != devfn ) >>> continue; >>> >>> - rmrr_identity_mapping(pdev->domain, 0, rmrr); >>> + rmrr_identity_mapping(pdev->domain, 0, rmrr, >>> + XEN_DOMCTL_DEV_RDM_RELAXED); >> >> ditto > > It doesn't matter when we're trying to remove a device since we don't > care this flag.
In such a case it helps to add a brief comment saying that the precise value passed is irrelevant. Or maybe this could be expressed by folding this and the "map" parameters of the function (in which case it might become self-documenting)? Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
