On Tue, Jun 16, 2015 at 11:24 AM, Ian Campbell <ian.campb...@citrix.com> wrote: > On Thu, 2015-06-11 at 16:30 +0000, Olaf Hering wrote: >> @@ -26,6 +28,7 @@ install: build >> [ -z "$(LIBBIN)" ] || $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN) >> $(INSTALL_DIR) $(DESTDIR)$(MAN1DIR) >> $(INSTALL_DIR) $(DESTDIR)$(MAN8DIR) >> + $(INSTALL_PROG) $(BIN) $(DESTDIR)$(bindir) > > Building on !x86 fails here because $(BIN) is empty: > install: missing destination file operand after > `/local/scratch/ianc/devel/committer-arm32.git/dist/install/usr/local/bin' > Try `install --help' for more information. > > I propose to continue trying to commit with this fixup patch folded in:
OK with me: Acked-by: George Dunlap <george.dun...@eu.citrix.com> > > diff --git a/tools/xentrace/Makefile b/tools/xentrace/Makefile > index 8932b73..3676812 100644 > --- a/tools/xentrace/Makefile > +++ b/tools/xentrace/Makefile > @@ -28,7 +28,9 @@ install: build > [ -z "$(LIBBIN)" ] || $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN) > $(INSTALL_DIR) $(DESTDIR)$(MAN1DIR) > $(INSTALL_DIR) $(DESTDIR)$(MAN8DIR) > +ifneq ($(BIN),) > $(INSTALL_PROG) $(BIN) $(DESTDIR)$(bindir) > +endif > $(INSTALL_PROG) $(SBIN) $(DESTDIR)$(sbindir) > $(INSTALL_PYTHON_PROG) $(SCRIPTS) $(DESTDIR)$(bindir) > [ -z "$(LIBBIN)" ] || $(INSTALL_PROG) $(LIBBIN) > $(DESTDIR)$(LIBEXEC_BIN) > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel