On Wed, 2015-06-03 at 16:01 +0800, Yang Hongyang wrote:
> move domain resume code into libxl_dom_suspend.c.

Even though it has "resume" in the name, I'm not sure that
libxl__domain_s3_resume is a good candidate for moving to the suspend
code, it's called only from libxl_send_trigger and IIRC we don't really
implement s3, just a fake version where the domain is paused/unpaused
(rather the destroyed and resumed, say.

Having moved libxl__domain_resume and libxl__domain_resume_device_model
into the same file I think the latter could become static. (If you do
that in this patch please say something along the lines of "pure code
motion except for making libxl__domain_resume_device_model static" in
the commit message)



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Reply via email to