"Jan Beulich" <jbeul...@suse.com> writes: >>>> On 13.07.15 at 11:08, <ian.campb...@citrix.com> wrote: >> On Mon, 2015-07-13 at 09:45 +0100, Jan Beulich wrote: >>> >>> On 10.07.15 at 18:24, <konrad.w...@oracle.com> wrote: >>> > On Tue, Jun 23, 2015 at 06:11:47PM +0200, Vitaly Kuznetsov wrote: >>> >> Log first 10 active grants of a domain. This function is going to be used >>> >> for soft reset, active grants on this path usually mean misbehaving >> backends >>> >> refusing to release their mappings on shutdown. >>> > >>> > Is there an particular reason 10 was choosen instead of 42 for example :-) >>> > >>> > Also the 10 should probably have an #define for it. >>> >>> Or even be command line controllable. >> >> That sounds like overkill to me, what's wrong with some random hardcoded >> number for a simple debug aid like this? > > From briefly looking at the code it seemed to be more than just a > debug aid (i.e. failing the operation if the count was exceeded). If > the number indeed only controls how many entries get printed, > then a #define certainly is fine.
Yes, it is just a debug aid in cases something goes wrong in future. This info is supposed to be useful for hardware domain admin to help finding misbehaving backends. -- Vitaly _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
