On 2015/7/13 17:40, Ian Campbell wrote:
On Mon, 2015-07-13 at 17:31 +0800, Chen, Tiejun wrote:
I still can't understand what I'm missing here after compared to other
contexts inside xlu_pci_parse_bdf().
Perhaps comparing to the CODING_STYLE document would help?
Looks the whole xlu_pci_parse_bdf() doesn't follow that,
if ( !strcmp(optkey, "msitranslate") ) {
pcidev->msitranslate = atoi(tok);
}else if ( !strcmp(optkey, "power_mgmt") ) {
pcidev->power_mgmt = atoi(tok);
}else if ( !strcmp(optkey, "permissive") ) {
pcidev->permissive = atoi(tok);
}else if ( !strcmp(optkey, "seize") ) {
pcidev->seize = atoi(tok);
}else if ( !strcmp(optkey, "rdm_policy") ) {
So I can do this as you're expecting now, but seems our change would
make the code style very inconsistent inside this function.
Thanks
Tiejun
So I have to paste this entirely,
}else if ( !strcmp(optkey, "rdm_policy") ) {
Should be:
} else if (!strcmp(optkey, "rdm_policy")) {
i.e. space after } before "else" and no extra spaces inside the if
condition.
if ( !strcmp(tok, "strict") ) {
if (!strcmp(tok, "strict")) {
Again no spaces within the if.
pcidev->rdm_policy = LIBXL_RDM_RESERVE_POLICY_STRICT;
}else if ( !strcmp(tok, "relaxed") ) {
Again add a space after } and remove those inside the if condition.
pcidev->rdm_policy = LIBXL_RDM_RESERVE_POLICY_RELAXED;
}else{
Should be:
} else {
XLU__PCI_ERR(cfg, "%s is not an valid PCI RDM
property"
" policy: 'strict' or
'relaxed'.",
tok);
goto parse_error;
}
}else{
and again "} else {"
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
