On 17/07/15 18:00, Ian Jackson wrote: > This adjust commit a49077e5 "Fix segfaults from `xl psr-cat-cbm-set` > command line handling": > > * Do not use the constant `required_argument' here (we simply use 1 > everywhere else). > > * Fix the minimum required arguments argument to SWITCH_FOREACH_OPT. > > Leave the separate check on optind, because it checks for too many as > well as too few arguments. > > (There are many things in xl which fail to check for too many > arguments. I do not intend to drain that swamp now: I started but > decided a complete overhaul of most of xl's command line argument > processing would be best.) > > This is just a code cleanup with no ultimate functional change. > > Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> > CC: Chao Peng <chao.p.p...@linux.intel.com> > CC: Andrew Cooper <andrew.coop...@citrix.com>
Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> I had not realised about the final parameter to SWITCH_FOREACH_OPT(). (The patch was a fix while I was attempting to get something else working) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
