Hi Roger,
On 21/07/15 11:16, Roger Pau Monné wrote:
> El 09/07/15 a les 22.42, Julien Grall ha escrit:
>> All the usage of the field pfn are done using the same idiom:
>>
>> pfn_to_page(grant->pfn)
>>
>> This will return always the same page. Store directly the page in the
>> grant to clean up the code.
>>
>> Signed-off-by: Julien Grall <[email protected]>
>> Cc: Konrad Rzeszutek Wilk <[email protected]>
>> Cc: Roger Pau Monné <[email protected]>
>> Cc: Boris Ostrovsky <[email protected]>
>> Cc: David Vrabel <[email protected]>
>
> Acked-by: Roger Pau Monné <[email protected]>
>
> With one style fix.
>
> [...]
>
>> static struct grant *get_grant(grant_ref_t *gref_head,
>> - unsigned long pfn,
>> + struct page *page,
>
> Indentation.
The indentation for the parameters of this function wasn't correct:
static struct grant *get_grant(grant_ref_t *gref_head,
- unsigned long pfn,
+^I^I^I struct page *page,
struct blkfront_info *info)
So "struct page *page" is correctly indent but not the remaining
parameter ("struct blkfront_info *info"). I will indent it correctly.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel
