On Fri, 2015-07-10 at 23:52 -0500, Chong Li wrote: > diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h > index d1d2ab3..58f1a7a 100644 > --- a/tools/libxc/include/xenctrl.h > +++ b/tools/libxc/include/xenctrl.h > @@ -915,6 +915,15 @@ int xc_sched_rtds_domain_get(xc_interface *xch, > uint32_t domid, > struct xen_domctl_sched_rtds *sdom); > So, here in the header, you're not changing the prototype of xc_sched_rtds_domain_{get,set} to use the typedef.
However... > +int xc_sched_rtds_vcpu_set(xc_interface *xch, > + uint32_t domid, > + xen_domctl_schedparam_vcpu_t *vcpus, > + uint16_t num_vcpus); > ... you hare using the typedef for the newly introduced functions xc_sched_rtds_vcpu_{get,set}(), and... > --- a/tools/libxc/xc_rt.c > +++ b/tools/libxc/xc_rt.c > @@ -27,7 +27,7 @@ > > int xc_sched_rtds_domain_set(xc_interface *xch, > uint32_t domid, > - struct xen_domctl_sched_rtds *sdom) > + xen_domctl_sched_rtds_t *sdom) > ...you are actually changing the _implementation_ of xc_sched_rtds_domain_{get,set}(). That's all rather inconsistent. Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel