Andrew Cooper writes ("Re: [PATCH v2 for-4.6 3/3] tools/libxl: Only continue
stream operations if the stream is still in progress"):
> check_all_finished() must only ever be called once for each started
> task. Having
>
> if ( inuse )
> continue()
> else
> check_all_finished()
>
> will make it far more likely to accidentally fire the overall stream
> callback twice.
I think extra calls to check_all_finished are harmless.
But anyway, I can see that this conversation isn't really converging.
I think there is no functional difference between the two approaches
we are debating. So this comes down to a matter of taste.
I don't want to put my foot down as maintainer, especially since you
wrote most of this code. So, I think the bikeshed might as well be
your favoured shade of orange:
Acked-by: Ian Jackson <ian.jack...@eu.citrix.com>
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
