On Mon, Jul 20, 2015 at 04:29:16PM +0200, Daniel Kiper wrote: > Current early command line parser implementation in assembler > is very difficult to change to relocatable stuff using segment > registers. This requires a lot of changes in very weird and > fragile code. So, reimplement this functionality in C. This > way code will be relocatable out of the box and much easier > to maintain. > > Suggested-by: Andrew Cooper <andrew.coop...@citrix.com> > Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com>
I did not look at the str* functions that were added in but just at how the parameters parsing was done. Also at the assembler code and with that Reviewed-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> .. snip.. > diff --git a/xen/arch/x86/boot/cmdline.c b/xen/arch/x86/boot/cmdline.c > new file mode 100644 > index 0000000..5ea50a4 > --- /dev/null > +++ b/xen/arch/x86/boot/cmdline.c > @@ -0,0 +1,396 @@ > +/* > + * Copyright (c) 2015 Oracle Co. Oracle Corporation. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
