On 12/08/15 03:35, Feng Wu wrote: > + GET_IREMAP_ENTRY(ir_ctrl->iremap_maddr, remap_index, iremap_entries, p); > + > + old_ire = new_ire = *p; > + > + /* Setup/Update interrupt remapping table entry. */ > + setup_posted_irte(&new_ire, pi_desc, gvec); > + ret = cmpxchg16b(p, &old_ire, &new_ire); > + > + ASSERT(ret == *(__uint128_t *)&old_ire);
You have still not addressed my issues from earlier series. This ASSERT() is buggy until you have a clear, detailed description of why it is claimed to be safe in this instance. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
