On Thu, Aug 13, 2015 at 10:22:25AM +0100, Ian Campbell wrote: > On Thu, 2015-08-13 at 09:24 +0100, Wei Liu wrote: > > @@ -1002,22 +1005,22 @@ int libxl__build_hvm(libxl__gc *gc, uint32_t > > domid, > > goto out; > > } > > > > - ret = hvm_build_set_params(ctx->xch, domid, info, state->store_port, > > At least this one doesn't return ERROR_*, it returns 0 or -1, assigning > such to rc is wrong and ultimately returning it from this function even > worse. > > Remind me why we aren't just taking Roger's original patch from < > 1438942688-7610-2-git-send-email-roger....@citrix.com> ? It seems we are > basically iterating towards it... >
Maybe we should just take that patch, that would save me from doing another round. Wei. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
