On Mon, Sep 14, 2015 at 10:49:00AM +0100, Stefano Stabellini wrote: > On Mon, 14 Sep 2015, Wei Liu wrote: > > On Fri, Sep 11, 2015 at 06:00:29PM +0100, Stefano Stabellini wrote: > > > The current libxl code doesn't deal with read-only drives at all. > > > > > > Upstream QEMU and qemu-xen only support read-only cdrom drives: make > > > sure to specify "readonly=on" for cdrom drives and return error in case > > > the user requested a non-cdrom read-only drive. > > > > > > > The commit message speaks about both upstream QEMU and traditional QEMU, > > but the code only touches upstream routine. I know that QEMU-trad uses > > different method to get disk parameters so _args_old is not an option, > > but perhaps something else is missing? Or is it because QEMU-trad is > > doing the right thing already? > > I know that QEMU naming is very confusing, but qemu-xen is the upstream > QEMU based tree which xen-unstable uses. We are only talking about > upstream QEMU based trees here. >
Ah, alright. Sorry for the noise. Acked-by: Wei Liu <wei.l...@citrix.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
