>>> On 21.09.15 at 13:34, <shuai.r...@linux.intel.com> wrote: > @@ -255,8 +260,9 @@ static void xc_cpuid_config_xsave( > regs[0] = regs[1] = regs[2] = regs[3] = 0; > break; > } > - /* Don't touch EAX, EBX. Also cleanup ECX and EDX */ > - regs[2] = regs[3] = 0; > + /* Don't touch EAX, EBX. Also cleanup EDX. Cleanup bits 01-32 of > ECX*/
This comment is off by one, and it will become stale the moment XSS_SUPPORT gets added to. Better to write this in a more generic way. Jan > + regs[2] &= XSS_SUPPORT; > + regs[3] = 0; > break; > } > } _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
