On Mon, Sep 21, 2015 at 9:36 AM, Linus Torvalds <torva...@linux-foundation.org> wrote: > On Mon, Sep 21, 2015 at 1:46 AM, Ingo Molnar <mi...@kernel.org> wrote: >> >> Linus, what's your preference? > > So quite frankly, is there any reason we don't just implement > native_read_msr() as just > > unsigned long long native_read_msr(unsigned int msr) > { > int err; > unsigned long long val; > > val = native_read_msr_safe(msr, &err); > WARN_ON_ONCE(err); > return val; > } > > Note: no inline, no nothing. Just put it in arch/x86/lib/msr.c, and be > done with it. I don't see the downside.
In the interest of sanity, I want to drop the "native_", too, since there appear to be few or no good use cases for native_read_msr as such. I'm tempted to add new functions read_msr and write_msr that forward to rdmsrl_safe and wrmsrl_safe. It looks like the msr helpers are every bit as bad as the TSC helpers used to be :( --Andy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel