On 22/09/15 10:10, Vijay Kilari wrote: > On Mon, Sep 21, 2015 at 7:50 PM, Julien Grall <julien.gr...@citrix.com> wrote: >> That's really ugly and you still let GICv2 hardware with nr_lpis != 0. >> As said on v6 I don't want to see any usage of nr_lpis in code except >> for letting the user restricting the number of LPIs supported. >> >> That means that all the code should use gic_nr_irq_ids to know the >> number of LPIs supported. Mixing the 2 usage will lead to big trouble >> latter. > > Here nr_lpis is used to update nr_irq_ids which is used by gic_nr_irq_ids().
That not the only usage of nr_lpis within this series. You are using it to create the IRQ desc for LPIs. We should have only one way to get the number of LPIs (i.e gic_nr_irq_ids()). Any attempt to have 2 different to retrieve the number of LPIs will be a problem later. >> >> So please move nr_lpis in gic-v3 as a parameter and don't export it. > > nr_lpis is user defined/initialized in irq.c . How can we pass this to gic-v3 > as > parameter?. You mean to have helper function to read/update nr_lpis? I meant moving the parameter in gic-v3 (i.e moving integer_param(...)). We can speak about moving the parameter in another place when we will have the need to. Regards, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel