>>> Andrew Cooper <andrew.coop...@citrix.com> 10/02/15 11:38 AM >>>
>On 02/10/15 06:49, Juergen Gross wrote:
>> --- a/xen/include/xen/libelf.h
>> +++ b/xen/include/xen/libelf.h
>> @@ -423,6 +423,7 @@ struct elf_dom_parms {
>> char loader[16];
>> enum xen_pae_type pae;
>> bool bsd_symtab;
>> + bool mod_start_pfn;
>
>The _pfn suffix here is confusing given the type of bool.
I had written a reply to that effect already, but then decided it's no less
confusing
than the name of the ELF note itself.
>Perhaps "has_initrd" is a better choice of name? The rest of the patch
>looks fine.
How would "has_initrd" express the purpose of the flag?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
