>>> On 14.10.15 at 18:24, <roger....@citrix.com> wrote: > In order to cope with types having multiple compat versions pass a parameter > to the fixup function so we can identify which compat version Xen is dealing > with.
Having peeked at patch 2, this won't help once another bit gets added to the tail of that structure. Also it doesn't seem logical that the previous compat handling got around without being passed the size explicitly. I.e. while perhaps more involved, I think the compat handling needs to be extended to allow for multiple versions. Or, since we have this under control going forward, don't even declare all the various compat structures in the public header (and only ever add to the tail). Then staying with the passing of size probably makes sense, but the fixup function then should use offsetof() instead of sizeof() (and validate unused tail bits are zero, so they can be used for something later on). Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
