On Sat, 2015-10-24 at 11:01 +0530, Harmandeep Kaur wrote: > turning parsing related functions xl exit codes towards using the > EXIT_[SUCCESS|FAILURE] macros, instead of instead of arbitrary > numbers > or libxl return codes. > > it doesn't include parse_config_data() which is big enough to deserve > its > own patch > > Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com>
> libxl_bitmap *cpumap)
> static int cpurange_parse(const char *cpu, libxl_bitmap *cpumap)
> {
> char *ptr, *saveptr = NULL, *buf = strdup(cpu);
> - int rc = 0;
>
> for (ptr = strtok_r(buf, ",", &saveptr); ptr;
> ptr = strtok_r(NULL, ",", &saveptr)) {
> - rc = update_cpumap_range(ptr, cpumap);
> - if (rc)
> + if (update_cpumap_range(ptr, cpumap))
> break;
> }
> free(buf);
>
> - return rc;
> + return 0;
> }
>
Oh, and also, here: I think rc is needed, in this case, to properly
deal with the failure of update_cpumap_range(), and poperly propagate
that failure to the caller.
If you want to get rid of it, you should do something like this, inside
the loop:
if (update_cpumap_range(ptr, cpumap)) {
free(buf);
return 1;
}
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
