Wei Liu writes ("Re: [Xen-devel] Ping: [PATCH v3] x86/HVM: correct page dirty marking in hvm_map_guest_frame_rw()"): > On Mon, Oct 26, 2015 at 07:09:06AM -0600, Jan Beulich wrote: > > Tools maintainers, could I please get an ack or otherwise on this > > adjustment?
I confess I'm out of my depth here. But thanks to Andrew Cooper's review, I'm happy to ack it without understanding it, except: > Does it make sense to use inverse logic that you set a flag to not > mark permanent pages dirty? I think that's a bit awkward, not sure if it > is worth it. > > I also realise that libxenctrl doesn't have stable interface so I'm a > bit two-minded for this. What kind of out of tree callers are going to use xc_shadow_control ? Not qemu, AFAICT, which would be my main worry. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel