Wei Liu, on Tue 10 Nov 2015 15:09:33 +0000, wrote: > On Tue, Nov 10, 2015 at 04:06:13PM +0100, Samuel Thibault wrote: > > Wei Liu, on Tue 10 Nov 2015 14:59:17 +0000, wrote: > > > I think I will port this patch to cxenstored at some point. As far as I > > > can tell cxenstored's data / space calculation is bogus in the same way. > > > > The low-level function return short reads and writes, yes, but that is > > handled at a higher level: initialize_fds sets timeout to 0 when there > > is still room (domain_can_read() or domain_can_write()). So it will > > improve performance a little bit, but not fix actual bugs. > > > > Yeah, that's true. Just IMHO it would be better if we can actually make > low level routine correct. That's orthogonal to what the upper layer is > doing and should prevent latent bug if upper layer logic changes.
Agreed. Samuel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
