>>> On 16.11.15 at 13:02, <david.vra...@citrix.com> wrote:
> On 16/11/15 11:52, Jan Beulich wrote:
>>>>> On 13.11.15 at 19:49, <david.vra...@citrix.com> wrote:
>>> @@ -2805,6 +2806,9 @@ int p2m_add_foreign(struct domain *tdom, unsigned
>>> long
> fgfn,
>>> prev_mfn = mfn_x(get_gfn(tdom, gpfn, &p2mt_prev));
>>> if ( mfn_valid(_mfn(prev_mfn)) )
>>> {
>>> + prev_page = mfn_to_page(_mfn(prev_mfn));
>>> + get_page(prev_page, tdom);
>>
>> If you're absolutely sure that this can never fail, then still at the very
>> least this imo should be documented by a respective ASSERT() (or
>> ASSERT_UNREACHABLE()).
>
> What are you suggesting may fail?
get_page()
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
