On Mon, 2015-11-30 at 11:23 +0100, Juergen Gross wrote: > On 30/11/15 11:20, Wei Liu wrote: > > On Thu, Nov 26, 2015 at 08:35:02AM +0100, Juergen Gross wrote: > > > > > > /* initrd parameters as specified in start_info page */ > > > - unsigned long initrd_start; > > > - unsigned long initrd_len; > > > + uint64_t initrd_start; > > > + uint64_t initrd_len; > > > > > > > I think these should be of type xen_vaddr_t. Doesn't make a difference > > in the end though. > > xen_vaddr_t seems not to be appropriate. It can be either a virtual > address or a pfn.
Did you mean a virtual address or a physical _address_? Potentially mixing addresses and frame numbers in a single variable seems liable to be confusing, at best. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel