On 11/30/15 9:51 AM, Julien Grall wrote: > Hi Doug, > > On 24/11/15 17:51, Doug Goldstein wrote: >> The following series is a follow on to the Kconfig conversion patch series. >> There are still more components to convert however this is the bare minimal >> to get everything working and get the options out of the existing makefiles. >> >> The CONFIG_HAS_ variables are there to match the behavior of the Linux >> CONFIG_HAVE_ variables. The purpose is to say that this hardware/profile/env >> supports this option while the CONFIG_ variable states that this option was >> requested on/off by user intervention. >> >> The UARTs are now uniformly prefixed as CONFIG_UART_ and dropping most of the >> CONFIG_HAS_ labeling for them. This means they are now user selectable as >> requested by Julien Grall in the prior review. The question I've got is >> the old config was just for selecting defaults. Users could enable the OMAP >> UART for arm64 for example but I'm not sure if that's valid. Currently this >> patchset makes those UARTs not user selectable if they were not previously >> defaulted on. But I would like some feedback on this if possible. > > While you know allow the user to enable a specific UART drivers, I still > have the same concern, i.e the default config used for ARM32 and ARM64 > will have all the UARTs drivers disabled.
Have you actually tested this? I have built it multiple times locally and that's not the case at all. The same UART drivers that are enabled in master today and enabled by default everytime. > > This means that when your series will be pushed, all the actual users of > ARM (included automated test suite such as osstest) will have to write > down a config in order to get Xen boot again on their board. > >> >> Ultimately my goal is to allow for more parts of the hypervisor to be turned >> off at compile time and potentially make it easier to include more >> experimental features by others which can be turned off by default. Also to >> provide the one true location for all possible knobs in the source code. >> >> The patch series can be grabbed at: >> https://github.com/cardoe/xen/tree/kconfig_v6 > > I can't find the kconfig_v6 branch on your github. > Sorry about that. Pushed. It was the same as kconfig_v5 just rebased up to a more recent version of staging. -- Doug Goldstein
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel