>>> On 07.12.15 at 10:16, <huaitong....@intel.com> wrote: > @@ -4605,6 +4605,18 @@ void hvm_cpuid(unsigned int input, unsigned int *eax, > unsigned int *ebx, > /* Don't expose INVPCID to non-hap hvm. */ > if ( (count == 0) && !hap_enabled(d) ) > *ebx &= ~cpufeat_mask(X86_FEATURE_INVPCID); > + > + /* X86_FEATURE_PKU is not yet implemented for shadow paging
Coding style. > + * > + * Hypervisor gets guest pkru value from XSAVE state, because > + * Hypervisor CR4 without X86_CR4_PKE disables RDPKRU instruction. > + */ > + if ( (count == 0) && (!hap_enabled(d) || !cpu_has_xsave) ) I has been said before that you should check the guest property here, not the host one. Without you doing so I can't even see the point of you adjusting the logic to set OSXSAVE above. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
