On Thu, 2015-12-10 at 18:27 +0000, Ian Jackson wrote:
> Ian Jackson writes ("Re: [OSSTEST PATCH 5/8] Schema: Support database
> schema updates"):
> > It does say that updates are applied in order. I will add `and
> > monotonically increasing' after `unique'. [etc etc]
>
> Here is v3 of this patch. I'll refrain from reposting the whole
> series.
>
> Ian.
>
> From a7fe7187f6237043f8d6aedeb714409b606af8e0 Mon Sep 17 00:00:00 2001
> From: Ian Jackson <[email protected]>
> Date: Thu, 10 Dec 2015 13:26:00 +0000
> Subject: [OSSTEST PATCH 5/8] Schema: Support database schema updates
>
> See schema/README.schema, introduced in this patch, for the design.
The README looks good now, thanks.
Code comments....
[...]
> diff --git a/mg-schema-create b/mg-schema-create
> index 54f1c76..1ee007b 100755
> --- a/mg-schema-create
> +++ b/mg-schema-create
> [...]
> @@ -46,16 +51,31 @@ while [ $# != 0 ]; do
> progress=:
> quietopt=-q
> ;;
> + --stop-before|--stop-after)
> + updates+=("$arg" "$1"); shift
> + ;;
> + --stop-before=*|--stop-after=*)
> + updates+=("$arg"); shift
> + ;;
> + --no-updates)
> + do_updates=false
> + ;;
> *)
> echo >&2 "bad usage ($arg)"; exit 127
> ;;
> esac
> done
>
> +export OSSTEST_DB_USEREAL_IGNORETEST='.*'
Why remove the safety catch in this context?
... and that seems to be my only comment.
Ian.
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel
